Skip to content

[WIP] Debug CAPI v1.8.x upgrade issue #5356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP] Debug CAPI v1.8.x upgrade issue #5356

wants to merge 2 commits into from

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Jan 6, 2025

/kind cleanup

What this PR does / why we need it:

PLEASE IGNORE: Trying to test methodically where the problem in upgrading to CAPI v1.8.8 is.

Which issue(s) this PR fixes:
Refs #5331

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2025
@mboersma
Copy link
Contributor Author

mboersma commented Jan 6, 2025

/test pull-cluster-api-provider-azure-apiversion-upgrade

@codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (71a3924) to head (a445c26).
Report is 17 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5356   +/-   ##
=======================================
  Coverage   52.43%   52.43%           
=======================================
  Files         272      272           
  Lines       29401    29401           
=======================================
  Hits        15417    15417           
  Misses      13178    13178           
  Partials      806      806

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma
Copy link
Contributor Author

mboersma commented Jan 6, 2025

/test pull-cluster-api-provider-azure-apiversion-upgrade

ERROR: (StorageAccountAlreadyExists) The storage account named capzcioidcissuer9340 already exists under the subscription.

@mboersma
Copy link
Contributor Author

mboersma commented Jan 6, 2025

Ok, CAPI v1.8.5 (no-op) passed the upgrade test. v1.8.6 next.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2025
@mboersma
Copy link
Contributor Author

mboersma commented Jan 6, 2025

/test pull-cluster-api-provider-azure-apiversion-upgrade

@mboersma mboersma force-pushed the bump-capi-one-eight branch from 020ee8c to a445c26 Compare January 6, 2025 20:46
@mboersma
Copy link
Contributor Author

mboersma commented Jan 6, 2025

/test pull-cluster-api-provider-azure-apiversion-upgrade

@mboersma mboersma mentioned this pull request Jan 14, 2025
Closed
4 tasks
@nawazkh
Copy link
Member

nawazkh commented Jan 14, 2025

/test pull-cluster-api-provider-azure-apiversion-upgrade

@k8s-ci-robot
Copy link
Contributor

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-apiversion-upgrade a445c26 link true /test pull-cluster-api-provider-azure-apiversion-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mboersma mboersma mentioned this pull request Jan 16, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mboersma @k8s-ci-robot @nawazkh